Import legacy JavaScript #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can you link this on the issue for transparency #4 |
4 tasks
Contributor
|
If it's not trivial to fix, then it is not a priority right now. The first milestone that we have to hit in this project is to reuse existing content in it's current form. Linting is therefore an optional requirement in this initial scope. If it's relatively reasonable to fix now, then I'm all for it. However, until we have a plan for the js content it might be best to hold off any changes to legacy content in case we modify it a lot. |
Contributor
Author
|
I don't suppose it'll take more than a couple of hours to fix up. It's just, significantly messier (lint-wise) than the other modules. |
2 tasks
needs a lot of fixing
Not ready yet: any links starting `/` need to be rewritten
adamblanchard
approved these changes
Apr 25, 2025
jason-vasilev
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.